Skip to content

Disabled Insecure request warning after login #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2023
Merged

Disabled Insecure request warning after login #320

merged 3 commits into from
Aug 30, 2023

Conversation

Bobbins228
Copy link
Contributor

@Bobbins228 Bobbins228 commented Aug 22, 2023 •
edited
Loading

Issue link

Closes #319

What changes have been made

Disabled Insecure request warning after login when setting skip_tls=True

Verification steps

Following a guided demo
Login with skip_tls=True
You should get a warning message similar to...

warnings.warn(
/opt/app-root/lib64/python3.8/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning: Unverified HTTPS request is being made to host <HOST>. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings

Follow the rest of the guided demo and you shouldn't see the warning again.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

KPostOffice
KPostOffice reviewed Aug 22, 2023
View reviewed changes
@Bobbins228 Bobbins228 requested a review from KPostOffice August 23, 2023 08:18
@KPostOffice
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
KPostOffice
KPostOffice approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to add an issue for replacing prints with the python logger library.

MichaelClifford
MichaelClifford approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice, MichaelClifford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1677680 into project-codeflare:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelClifford MichaelClifford MichaelClifford approved these changes

@KPostOffice KPostOffice KPostOffice approved these changes

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

Assignees

@MichaelClifford MichaelClifford

@KPostOffice KPostOffice

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suppress insecure request warnings when setting skip_tls to True
4 participants
@Bobbins228 @KPostOffice @MichaelClifford @openshift-merge-robot